Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gatsby-remark-dvc-linker isn't working correctly for mlem.ai #19

Closed
julieg18 opened this issue May 24, 2022 · 1 comment · Fixed by #16
Closed

gatsby-remark-dvc-linker isn't working correctly for mlem.ai #19

julieg18 opened this issue May 24, 2022 · 1 comment · Fixed by #16
Assignees
@yathomasi
Labels
🐛 type: bug Something isn't working.

Comments

@julieg18
Copy link
Contributor

julieg18 commented May 24, 2022 •
edited by jorgeorpinel

mlem.ai isn't automatically turning mlem or mlem.api commands into links.

When I first started debugging, I thought the issue was just that the commandLinker (and apiLinker) are configured to check for only dvc commands.

But when I tested it locally, getItemByPath wasn't running correctly for some reason. Maybe this was just an issue with my local test though and we just need to adjust the DVC_REGEXP 🤔

cc @rogermparent, @yathomasi

Context: iterative/mlem.ai#69
@julieg18 julieg18 added the bug label May 24, 2022
@julieg18 julieg18 mentioned this issue May 24, 2022
Open
4 tasks
@yathomasi yathomasi mentioned this issue May 25, 2022
Merged
@yathomasi
Copy link
Contributor

Thanks, @julieg18. I went ahead and added a fix on small PR I was working on.

@yathomasi yathomasi self-assigned this May 25, 2022
@jorgeorpinel jorgeorpinel added 🐛 type: bug Something isn't working. and removed bug labels Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yathomasi yathomasi

Labels
🐛 type: bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add mlem commands, fix command and api linkers iterative/gatsby-theme-iterative
3 participants
@jorgeorpinel @yathomasi @julieg18