Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement interface for enrichments #46

Closed
aguschin opened this issue Mar 10, 2022 · 4 comments
Closed

Implement interface for enrichments #46

aguschin opened this issue Mar 10, 2022 · 4 comments
Assignees

Comments

@aguschin
Copy link
Contributor

To provide something like

$ gto describe iris --version v1
# Output can include DVC metrics, params, plots, dependencies, etc.
# Output can also include MLEM types, frameworks, methods, etc.
# Future output could include LDB data.

we need to implement modules like mlem.gto and dvc.gto to be later automatically discovered by GTO and used to fetch all details about artifacts.

To implement them, we first need to implement abstract interface they must satisfy.

@aguschin
Copy link
Contributor Author

While using artifact registry, it could be the case when artifact itself was updated and enrichments are no longer correct.
$ gto describe should warn a user about these cases. It could be good if we could include this in #52 to get at least some idea how it should be done.

@aguschin
Copy link
Contributor Author

As mentioned by @shcheklein, when DVC is installed as binary, GTO may not be able to discover DVC Python API. We need to support CLI as a fallback then. As an option, we can list dvc and mlem in config file gto.yaml so GTO will know what to search for.

@aguschin aguschin added v2 Tasks for the second release and removed p1-high High priority labels Mar 21, 2022
@aguschin
Copy link
Contributor Author

@mike0sv have created a good PR #52 that showcase how this should work. It's decided to postpone this functionality and implement it for the next product release.

@aguschin aguschin added p1-high High priority and removed v2 Tasks for the second release labels Apr 22, 2022
@aguschin aguschin added this to the First GTO release milestone Apr 22, 2022
@aguschin
Copy link
Contributor Author

As a part of this task, we need to think about how to show discovered models in Studio MR. How it will be handled? How we'll show MLEM-only models there? Do you hide a MLEM model once GTO annotation matches the path (including previous commits)?

@aguschin aguschin removed the p1-high High priority label Jul 25, 2022
@aguschin aguschin closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant