Hold trades spam logs every iterations

[nakapola]

Version 7.7.1

My config use throttle process at 3 seconds and this check seems to checking every 3 seconds too

2021-08-18 03:43:19 NostalgiaForInfinityNext: WARNING - The 'hold-trades.json' file was not found. Looked in '/home/***/freqtrade/user_data/strategies/hold-trades.json'. HOLD support disabled.
2021-08-18 03:43:22 NostalgiaForInfinityNext: WARNING - The 'hold-trades.json' file was not found. Looked in '/home/***/freqtrade/user_data/strategies/hold-trades.json'. HOLD support disabled.
2021-08-18 03:43:25 NostalgiaForInfinityNext: WARNING - The 'hold-trades.json' file was not found. Looked in '/home/***/freqtrade/user_data/strategies/hold-trades.json'. HOLD support disabled.
2021-08-18 03:43:28 NostalgiaForInfinityNext: WARNING - The 'hold-trades.json' file was not found. Looked in '/home/***/freqtrade/user_data/strategies/hold-trades.json'. HOLD support disabled.
2021-08-18 03:43:31 NostalgiaForInfinityNext: WARNING - The 'hold-trades.json' file was not found. Looked in '/home/***/freqtrade/user_data/strategies/hold-trades.json'. HOLD support disabled.
2021-08-18 03:43:34 NostalgiaForInfinityNext: WARNING - The 'hold-trades.json' file was not found. Looked in '/home/***/freqtrade/user_data/strategies/hold-trades.json'. HOLD support disabled.
2021-08-18 03:43:37 NostalgiaForInfinityNext: WARNING - The 'hold-trades.json' file was not found. Looked in '/home/***/freqtrade/user_data/strategies/hold-trades.json'. HOLD support disabled.
2021-08-18 03:43:40 NostalgiaForInfinityNext: WARNING - The 'hold-trades.json' file was not found. Looked in '/home/***/freqtrade/user_data/strategies/hold-trades.json'. HOLD support disabled.
2021-08-18 03:43:43 NostalgiaForInfinityNext: WARNING - The 'hold-trades.json' file was not found. Looked in '/home/***/freqtrade/user_data/strategies/hold-trades.json'. HOLD support disabled.
2021-08-18 03:43:46 NostalgiaForInfinityNext: WARNING - The 'hold-trades.json' file was not found. Looked in '/home/***/freqtrade/user_data/strategies/hold-trades.json'. HOLD support disabled.

[nakapola]

Figured I could create empty hold-trades.json to shut this up. But I will not close this issue in case of finding a better solution.

edit: also put {} inside hold-trades.json

[TheWilsonDelta]

Concur, getting same warning on repeat

[yokeap]

I use docker and i put hold-trades.json in /user_data/strategies but it's not solve.

[BaptisteBuvron]

@yokeap
On docker, @abc112116 's solution worked for me.

[genhack]

I merge the Issue there. Better solution is make an on off method for enable this or disable on top of the strategy. Im not a python guyz.

Hy @iterativv after upgrade i see a lot of warning in console about Hold support file not found. The code show a infinite loop of this message:

else: looked_in = f"'{hold_trades_config_file_resolve}'" log.warning( "The 'hold-trades.json' file was not found. Looked in %s. HOLD support disabled.", looked_in )
Can be possible to make a direct call in method for Hold Support at the top of the startegy ?
Thanks for the work!

[s0undt3ch]

I think it's best if we just remove that message?
Or do we want a config parameter to enable/disable it?

[genhack]

Better a config for enable and disable the feature is almost an option.

[eSeR1805]

I think a time interval approach would also compliment the enable/disable flag. Maybe check file each 5m/15m/30m/1h or something that's not too often.

[genhack]

@eSeR1805 i agree, but this futures and next should be on top and need a _on method for a good mix of settings like the other. About the full fix, a time interval is a good ways outside freqtrade but i think, isnt the proper solution, the countdown can be a problem when a large range of the time is set or if some sell signal come before the refresh. Better option coud be a command in telegram bot easy to add and you can work outside with the strat. My Noob POV.
@s0undt3ch Thanks for the work you made!

[eSeR1805]

This is something we (hopefully) don't need to use too often. You need to reload anyway when you add something to the hold trades file. Added dummy file to repo through 3f0c1a4

[s0undt3ch]

You need to reload anyway when you add something to the hold trades file.

Not since the cache class implementation was added.