Some slightly malformed PDFs have PdfNull as AcroForm entry #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi all - any chance of getting this pull request accepted? |
|
Can one of the admins verify this patch? |
|
@trumpetinc, could you attach a test file? |
|
Unfortunately, the file in question contained sensitive information, so I
am not able to submit the sample file that caused this request.
I suppose we could manually craft a file that has pdfnull for the acroform
entry? Will itext allow us to override that?
K
Kevin Day
trumpet
480.961.6003 x 1002
kevin@trumpetinc.com
www.trumpetinc.com
…On Nov 2, 2017 1:27 AM, "Pavel Alay" ***@***.***> wrote:
@trumpetinc <https://github.com/trumpetinc>, could you attach a test file?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#32 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGT-eMMDw3Ws9V1txxx_dgyxPu-UKwvlks5syXzhgaJpZM4NQCkw>
.
|
|
ok - I figured out how to add a unit test without relying on the original source document. This fails with current code, passes with the fixed code. |
|
@trumpetinc Thanks for the contribution! |
|
Hi @trumpetinc, Right now itext/itextpdf has been deprecated in favor of itext/itext7, although we will continue to incorporate security fixes in itext/itextpdf (iText5). Could you check if the issue exists in itext/itext7 so we can incorporate your fix? Thank you for contribution, it is appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing ClassCastException on the return from PdfReader.getPdfObject() in PdfStamperImpl b/c PdfNull was being returned instead of null - best to not cast at that point and do an instanceof check later.