Master #33

Rampradeepb · 2017-10-05T11:45:39Z

Hi,

Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/commons/imaging/ImageFormats
at com.itextpdf.text.pdf.pdfcleanup.PdfCleanUpRenderListener.processImage(PdfCleanUpRenderListener.java:316)

The import class has typo mistake in PdfCleanUpRenderListener.java

org/apache/commons/imaging/ImageFormats (Wrong)
org/apache/commons/imaging/ImageFormat (Correct)

Thanks,

DEV-1812

…flicts

Conflicts: itext/src/main/java/com/itextpdf/text/Version.java

#22

Additional changes required on Jenkins: * Install JDK 5 and 7 * Set environment variables JAVA5_HOME and JAVA7_HOME * Run Maven with -P compileWithLegacyJDK Closes QA-93

Fix Field rotation not taken into account when flattening fields, Add test-files for flattening rotated form fields to flattening test DEV-1817

SUP-1624

Fix matrix not being overwritten when no scaling is necessary Form fields flattened into XObject and placed in the same way as adobe flattening. DEV-1817, SUP-1612

errors if we cache too many

… trumpetinc-develop

DEV-1828

DEV-1823

SUP-1699

DEV-1823

SUP-2042, DEV-1865

DEV-1879

DEV-1884

DEV-1862

DEV-1863

DEV-1879

It doesn't make sense from pdf point to have dictionary with null key. DEV-1862

The whole point of disabled fractional metrics is to round up scaled font metrics to integers, so calculating bounds in not original scale and then scaling it down didn't make sense. DEV-1881

Note that RenderingHints may still be different for PdfGraphics2D and inner Graphics2D if someone explicitly gets rendering hints and will change then not through PdfGraphics2D. DEV-1881

DEV-1913

Jenkins was failing the test containing Cyrillic characters

This logic is closer to how Acrobat displays freetext annotations, and also fixes NPE while processing such annotations with PdfContentStreamProcessor after flattening. DEV-1896

Acrobat resolves such names in DA as well. DEV-1896

DEV-1885

…versions

iText-CI · 2017-10-05T11:45:41Z

Can one of the admins verify this patch?

blagae · 2017-10-05T12:07:45Z

Hi @Rampradeepb ,

That seems to be incorrect: the enum ImageFormats is clearly available, as you can see here: https://github.com/apache/commons-imaging/tree/master/src/main/java/org/apache/commons/imaging

If you have a NoClassDefFoundError, then any of several problems may be occurring, but most likely it is a dependency issue in your project. A few suggestions:

you do not have a dependency that contains this class on your classpath
you have several dependencies that contain this class on your classpath
the platform you're developing on, apparently Android given the fact that you're trying to merge into the itextg branch, may have an old build of this commons.imaging that does not contain this class.

I am closing this PR, because it isn't a contribution to iText.

blagae · 2017-10-06T07:03:08Z

@Rampradeepb a commit from 2013 in commons-imaging has apparently renamed this enum. So if you are sure that you have one, and only one, version of commons-imaging on your classpath, then you should probably build commons-imaging from an up to date version of the source code.

Rampradeepb · 2017-10-06T07:06:54Z

Ok Sure. Thanks for the help

Benoit Lagae and others added 30 commits October 4, 2016 16:01

Test that absent OCGs entry in Catalog is caught

c054a70

Catch absent OCGs entry in Catalog

bf9e893

DEV-1812

[RELEASE] 5.5.10-SNAPSHOT -> 5.5.11-SNAPSHOT

e62c845

[RELEASE] updating develop poms to master versions to avoid merge con…

3fd567d

…flicts

Merge branch 'master' into develop

b05e62f

Conflicts: itext/src/main/java/com/itextpdf/text/Version.java

Fix IndexOutOfBoundsException in PdfPTable.writeSelectedRows

3840199

Add test for writeSelectedRows non-zero startRow

23c6eb5

#22

Refactor loop bounds

ebcf8b3

Remove incompatible @OverRide annotation

469ba44

Cross compile with Java 5/7

d6a7a7c

Additional changes required on Jenkins: * Install JDK 5 and 7 * Set environment variables JAVA5_HOME and JAVA7_HOME * Run Maven with -P compileWithLegacyJDK Closes QA-93

Fix Form Field Flattening not respecting rotation

e215211

Fix Field rotation not taken into account when flattening fields, Add test-files for flattening rotated form fields to flattening test DEV-1817

Fix handling of dangling page references

b245200

SUP-1624

Fix form field flattening rotation bug

0eb0bff

Fix matrix not being overwritten when no scaling is necessary Form fields flattened into XObject and placed in the same way as adobe flattening. DEV-1817, SUP-1612

Closing the stream after reading it in decodeIdat()

c5c53f1

Added mkdirs to a test

aabeddb

Inner operator classes should have been static

675ba20

PDF files that contain a large number of fonts can cause out of memory

4b0187b

errors if we cache too many

added check marker for BDC when nested in block which is to be removed

d84d0ed

added a test for the OCGParser to demonstrate the missbehavior

3b635b2

xtra: improve OCG removal test (cmp file & assert)

0056b60

xtra: OCG fix of test in private repo

8b7dab0

Changed cach management strategy to use weak references

f4d2c85

Merge branch 'develop' of https://github.com/trumpetinc/itextpdf into…

5337544

… trumpetinc-develop

support TIFF images without compression tag

4c48b93

DEV-1828

PdfReader: close ZIP resource after FlateDecode

28ab2b0

Apply producer line at closing.

fb80a02

DEV-1823

Fix incorrect use of getCurrentPage when stamping

08d3494

SUP-1699

Fix possible errors with null producer line.

a752bb1

DEV-1823

Make producer line override silent in any cases.

d84fc33

DEV-1823

Bump maven-javadoc-plugin to 2.10.4

243c053

dlichtenberger-chemdox and others added 25 commits July 25, 2017 16:56

Performance: avoid expensive logging calls in table rendering

08cbe1f

SUP-2042, DEV-1865

Avoid expensive logging calls throughout the project

8d456d8

Enable line style operators processing while cleaning up. Fix cmps.

4d3958d

DEV-1879

Port 07dd2fa. Suggested by Jorrit Schippers.

db3f309

DEV-1884

Add a new test related to slash-asterisk comments.

9aaafcd

DEV-1884

Add test for null keys in PdfDictionary from c# pull request

f8f6d32

DEV-1862

Prevent XXE-vulnerability

ad38371

DEV-1863

Replace remote image URL with static image from resources

c494099

Add missing copyright headers

d056987

Add new cleanup test.

691a097

DEV-1879

Throw exception on adding null key to PdfDictionary

4dabef8

It doesn't make sense from pdf point to have dictionary with null key. DEV-1862

Fix string bounds calculations with fractional metrics disabled

31e2a20

The whole point of disabled fractional metrics is to round up scaled font metrics to integers, so calculating bounds in not original scale and then scaling it down didn't make sense. DEV-1881

Make PdfGraphics2D more consistent with inner Graphics2D

184ebac

Note that RenderingHints may still be different for PdfGraphics2D and inner Graphics2D if someone explicitly gets rendering hints and will change then not through PdfGraphics2D. DEV-1881

Port Datamatrix improvements from iText7

af4fe63

DEV-1913

remove unused variable

98224e5

Use unicode points for Cyrillic contents

78c6b2a

Jenkins was failing the test containing Cyrillic characters

Add missing copyright headers

e79227a

Explicitly set built-in fonts on freetext annotations flattening

b4a29ef

This logic is closer to how Acrobat displays freetext annotations, and also fixes NPE while processing such annotations with PdfContentStreamProcessor after flattening. DEV-1896

Support short font names in DA for freetext annotations

133eabb

Acrobat resolves such names in DA as well. DEV-1896

Port cb0b508: Copy all global subroutines to GSubr INDEX.

04f38fc

DEV-1885

Port ebc4912: Prevent overflow while offsets writing.

9bef56e

DEV-1885

Fix cmps.

8e5d799

DEV-1885

[RELEASE] 5.5.12-SNAPSHOT -> 5.5.12

0921961

[RELEASE] updating poms for branch'release/5.5.12' with non-snapshot …

6e136be

…versions

[RELEASE] merging 'release/5.5.12' into 'master'

3ca54cc

blagae closed this Oct 5, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Master #33

Master #33

Rampradeepb commented Oct 5, 2017

iText-CI commented Oct 5, 2017

blagae commented Oct 5, 2017

blagae commented Oct 6, 2017

Rampradeepb commented Oct 6, 2017

Master #33

Master #33

Conversation

Rampradeepb commented Oct 5, 2017

iText-CI commented Oct 5, 2017

blagae commented Oct 5, 2017

blagae commented Oct 6, 2017

Rampradeepb commented Oct 6, 2017