Fix NPE when adding illegal child to nameless PdfLayer #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a PdfLayer is created without a name, e.g., via PdfLayer.createTitle() or when reading OCProperties, and later a child that has already another parent is added to this layer, the addChild(PdfLayer) method throws a NullPointerException. The is because the name is retrieved and immediately converted to a Unicode string, even if it is null.
|
Can one of the admins verify this patch? |
|
Hi @salsolatragus, Right now itext/itextpdf has been deprecated in favor of itext/itext7, although we will continue to incorporate security fixes in itext/itextpdf (iText5). Could you check if the issue exists in itext/itext7 so we can incorporate your fix? Thank you for contribution, it is appreciated. |
|
@avlemos the problem is fixed in itext7. @andreasrosdal: I've migrated this PR to OpenPDF5, too: LibrePDF#2 |
|
@salsolatragus Thanks! |
|
Are any of these relevant for https://github.com/LibrePDF/OpenPDF also? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
PdfLayeris created without a name, e.g., viaPdfLayer.createTitle()or when reading OCProperties, and later a child that has already another parent is added to this layer, theaddChild(PdfLayer)method throws aNullPointerException. The is because the name is retrieved and immediately converted to a Unicode string, even if it isnull.This problem was identified by our automated detector MUDetect. We would very much appreciate your feedback on our patch. Thank you very much!