Improve error reporting when processing bookmark destination

[salsolatragus]

When makeBookmarkParam is invoked with an empty dest array, fetching the first element without a guard will lead to an IndexOurOfBoundsException thrown by the underlying ArrayList. To prevent such obscure errors, we capture this illegal dest state and throw a more expressive exception instead.

[iText-CI]

Can one of the admins verify this patch?

[avlemos]

Hi @salsolatragus,

Right now itext/itextpdf has been deprecated in favor of itext/itext7, although we will continue to incorporate security fixes in itext/itextpdf (iText5).

Could you check if the issue exists in itext/itext7 so we can incorporate your fix?

Thank you for contribution, it is appreciated.

[salsolatragus]

@andreasrosdal: thanks for the pointer, I've created LibrePDF#1

@avlemos: The class with the issue doesn't seem to exist in itext7. I assume that the problematic code was deleted with it.