Update CRLVerifier.java #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is wrong to ask the signdate must be after the thisUpdate time of crl. For example, one pdf was signed in 2018-08-27 and the cert didn't be revoked. The CA update crl daily, so the thisUpdate time is 2018-08-28 and nextUpdate time is 2018-08-29.
|
Can one of the admins verify this patch? |
|
@lvtaoleo please don't tag random people. The people you tagged, will not be assigned to handle your PR. Thank you. |
|
Hi @lvtaoleo, Right now itext/itextpdf has been deprecated in favor of itext/itext7, although we will continue to incorporate security fixes in itext/itextpdf (iText5). Could you check if the issue exists in itext/itext7 so we can incorporate your fix? Thank you for contribution, it is appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is wrong to ask the signdate must be after the thisUpdate time of crl. For example, one pdf was signed in 2018-08-27 and the cert didn't be revoked. The CA update crl daily, so the thisUpdate time is 2018-08-28 and nextUpdate time is 2018-08-29. If I verify the pdf in 2018-08-28 and the cert isn't in the crl, it should be return the good status when check the revocation status of the cert.