-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Having some problems with using this with WSK #24
Comments
Heya @gauntface, I'll download the WSK and have a look into the issue. It's a bit hard to debug this new version as most of the processing is done with a RealFaviconGenerator API call, but I think the error is due to the lack of a callback. Also there's a Gulp plugin now so I recommend using that: https://www.npmjs.com/package/gulp-favicons. Can you send me your favicon image file you're using? |
Any issues you find, it would be good to reveal them in the logs, always a black box at the moment. I'll try out the gulp-favicons. Just to let your know I'm working on the material-sprint branch AND I have an image not in the repo - happy to share, but any image to test would be fine. |
@gauntface I tried out gulp-favicons by adding a new task to WSK and it appears to work okay:
Long story short, the Gulp plugin works a little differently by parsing an HTML tag:
It removes it upon processing so there's no chance of a W3C validation error or anything. I'd like to make it accept an HTML file or an image when I get around to it. |
Thanks for your help @haydenbleasel. I'm getting different results to you:
I'm also slightly lost as to what this is now doing. The gulp.src is app/index.html, we also have the html set to dist/index.html (If we can drop the dist/index.html one then thats awesome). I'm also not following what Pulling info out of the HTML file is actually really helpful for our usecase as it means we can push this to a build only step. |
@gauntface I definitely agree it's confusing, I'd like to spend some time on making it simpler. Basically we're reading an HTML file instead of an image for streaming reasons - you can pipe it onto your
It accepts an HTML file with a custom metatag and returns an HTML file with new metatags. The produced images are basically an "add-on" which is why you need the As for the error you're getting, I usually get that if my metatag is missing or the image reference is wrong. For you, this should be something like:
I really need to either write down a list of these errors in the readme or make better error messages. Hope this helps and sorry for the hassle :S |
Right, further digging (I'll post my code to get to this point), but the issue with a spawn task: $ gulp favicons /Users/mattgaunt/Programming/Code/web-starter-kit/node_modules/gulp-favicons/index.js:105 I'm assuming this is an issue with the imagemagick but after installing it - I still can't get the damn thing to work :( |
Ah - requires graphicsmagick too: https://www.npmjs.com/package/gm |
So I've finally got it looking like it's working, but mashed things up into this PR: #25 |
@gauntface Awesome, thanks so much. Was it really necessary as part of the commit to change all my indentation and coding style though? I'm a huge fan of JSLint so that's from where most of my style is based. Also, Addy proposed splitting gulp-favicons into a new repository so the new PR has to go here: https://github.com/haydenbleasel/gulp-favicons. Sorry about that :/ |
I'm just trying to add in the new version of this task into WSK and I'm having a few issues:
At the moment the task is:
The log for this is minimal:
No images seem to get created anywhere (assuming /dist/app-touch-startup-image-*.png would be the location it would be created.
Thanks,
Matt
The text was updated successfully, but these errors were encountered: