Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document support for multiple sizes? #30

Closed
indolering opened this issue Jan 30, 2015 · 4 comments
Closed

Document support for multiple sizes? #30

indolering opened this issue Jan 30, 2015 · 4 comments

Comments

@indolering
Copy link

You thank some people in the readme for their input on multiple sizes. Has this actually made it into the production system? If so, could you document support for it?

@haydenbleasel
Copy link
Contributor

Yeah sorry, it's a bit weird. Old implementation (1.x.x) of Favicons has support for multiple image sizes based on the icon size. New one has support for multiple image sizes based on the platform, different syntax. I have to update this, thanks for pointing it out!

@indolering
Copy link
Author

It is still not clear to me how I would, for example, specify a primary SVG for the larger sizes and a secondary image for 16x16 and 24x24.

@haydenbleasel
Copy link
Contributor

That implementation of size-based images was in version 1. Since then, we've started using the RealFaviconGenerator API which gives us the ability to use platform-based images only, for example:

A master picture can also be declared for each platform. For example, if a specific icon was designed for iOS:

"ios": {
    "master_picture": {
        "type": "url",
        "url": "http://somesite.com/some_pic.png"
    },
    "picture_aspect": "no_change"
},

With that in mind, if you'd like this functionality to be in the RealFaviconGenerator API then I recommend contacting Philippe as it's totally up to him :)

As for our functionality at the moment, you can check it out here:

https://github.com/haydenbleasel/favicons#multiple-sources

@troxler
Copy link

troxler commented Aug 16, 2016

@haydenbleasel Has this changed in the meantime? The configuration example states that source can be an "array of { size: filepath }". But how exactly would be the notation of that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants