-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.0.0 is not working on Windows #403
Comments
Any details? |
I'm testing on mac and it isn't working for me either. No errors are being thrown but my favicons are just not being generated. 7.0.0-beta.1 and 7.0.0-beta.4 also works for me. 7.0.0-beta.5 doesn't work for me either. |
May you provide more details? How do you test? May it happen that you use a callback to get a result? Callbacks are not supported anymore (since beta.5).
|
No I didn't update my code to reflect the switch to promises so I guess that's the issue. Thanks for the heads up but I would humbly suggest that you announce these kind of changes in a changelog document, not only in the readme. Especially when you change the API itself between a beta version and the corresponding release. |
The change also isn't reflected on the npm readme |
...as opposed to 7.0.0-beta.4 for example, which does work on Windows.
The text was updated successfully, but these errors were encountered: