Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset versioning #80

Closed
haydenbleasel opened this issue Dec 11, 2015 · 4 comments
Closed

Asset versioning #80

haydenbleasel opened this issue Dec 11, 2015 · 4 comments

Comments

@haydenbleasel
Copy link
Contributor

See: RealFaviconGenerator/gulp-real-favicon#5

Refer to RFG API for implementation style.

@strarsis
Copy link

So those links to extra gulp plugins indicate that URL-based cache busting
is rather the job of a different/extra plugin (I agree btw)?

With best regards

@haydenbleasel
Copy link
Contributor Author

@strarsis I wish it could be, but since Favicons generates HTML and files but only returns files to the stream, only the files will get versioned if we use a seperate gulp plugin i.e. The HTML links will be incorrect.

@strarsis
Copy link

Also, for example, I would like to just include the generated HTML in a Jade layout template:

include ./generated/favicon.html

Can favicons also generate the necessary markup from scratch without a template index.html?
It seems to expect an existing HTML file, when I omit the option, no html is generated that I could include.

IMHO the generated HTML should just be that - minimal without things like hashes.
Then it can be postprocessed using another gulp plugin like gulp-rev-append.
Also, the HTML could be injected into the stream, too, a filter step can then be used to select either the image files or the HTML file using gulp-filter.

@haydenbleasel
Copy link
Contributor Author

@strarsis Actually that's a good idea. Post favicons generation, you can use something like gulp-useref + gulp-rev + gulp-rev-replace to sort this stuff out. I've done something similar in Catalyst if that helps. Nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants