Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for edit charts #208

Open
aeubanks opened this issue Apr 9, 2024 · 1 comment
Open

Better support for edit charts #208

aeubanks opened this issue Apr 9, 2024 · 1 comment

Comments

@aeubanks
Copy link
Contributor

aeubanks commented Apr 9, 2024

In general support for edits in itgmania isn't great. If a song only has edit charts, playing any of them ends immediately (I believe we use the last note of any non-edit chart to determine when a song ends).

We should probably treat edits more like normal charts (e.g. pump doesn't only have 4/5 difficulties, but an arbitrary number of charts per song).

@nabulator
Copy link
Contributor

both issues are probably addressed better in the Simply Love repository, which actually manages edit mode and other theming behavior.

As for your first point, do you mean that your edit charts don't play at all? What does immediately mean? Immediately after the last note seems normal. It seems odd you believe that edit charts are different from normal charts. Could you provide an example where this is the case for you?

As for your second point, I'm not sure what you mean when you say 'more like normal chart' but you are allowed to have an arbitrary number of edit charts. We have set difficulties again out of historical momentum but it is not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants