Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolls sometimes aren't displayed as held #232

Open
teejusb opened this issue Apr 26, 2024 · 0 comments
Open

Rolls sometimes aren't displayed as held #232

teejusb opened this issue Apr 26, 2024 · 0 comments

Comments

@teejusb
Copy link
Collaborator

teejusb commented Apr 26, 2024

This seemingly happens when you have a roll that coincides with a tap note on the same arrow. Sometimes the roll isn't displayed as being held/rolling even the player is (see video). This is not an ITGmania specific bug.

2023-04-21_13-15-32FIX.mp4

This is either noteskin or engine bug but unsure which one. Current theory is that it has to do with chord cohesion/how jumps are evaluated. We think if the roll is hit early (say in the way off window), but we hit the tap note on time then we might run into this issue. Holds seem to never have this problem though so unsure if that's actually the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant