Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Card: Allow for custom aspect ratio in collection variant #146

Closed
daneah opened this issue Jul 8, 2021 · 0 comments · Fixed by #157
Closed

Image Card: Allow for custom aspect ratio in collection variant #146

daneah opened this issue Jul 8, 2021 · 0 comments · Fixed by #157

Comments

@daneah
Copy link
Member

daneah commented Jul 8, 2021

The problem

I want to use the collection variant of the image card to get its showy heading style, but I also have images that aren't 4:3.

The solution

Be able to specify the aspect ratio of the image explicitly instead of hard coding it, or better, allow the card to shrink naturally like it does for the default variant.

Alternatives considered

We could use the default variant to shrink to the image's natural aspect, but it doesn't have a showy heading style. We could create new images that are 4:3, but that doesn't track well.

Additional information

It may be that the "collection" variant is a bit of a tightly-scoped name as well—it's a bit of a "showcase" variant that may not always be showcasing a collection per se. That's really a semantics issue, but good to have language that can be used ubiquitously.

@daneah daneah changed the title Allow for custom aspect ratio in image card collection variant Image Card: Allow for custom aspect ratio in collection variant Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant