Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @lit/react to build React components instead of doing it manually ourselves #728

Open
daneah opened this issue Mar 16, 2024 · 3 comments

Comments

@daneah
Copy link
Member

daneah commented Mar 16, 2024

The problem
Managing the React components is a maintenance burden and prone to error. Doing this ourselves incurs a whole area of work around duplicating component stories for React and building a composed Storybook, all of which add complexity and get in the way often.

The solution

  • Use the offical @lit/react package to build the React components for consumers
  • Document what to expect about component property names and event handling
  • Stop managing a React Storybook altogether
  • Stop managing a composed Storybook
@daneah
Copy link
Member Author

daneah commented Mar 21, 2024

custom-element-react-wrappers is another alternative if it proves useful/necessary

@Niznikr
Copy link
Collaborator

Niznikr commented Apr 29, 2024

@daneah
Copy link
Member Author

daneah commented Apr 29, 2024

I saw that as well and shared around internally @Niznikr, exciting development! Thanks for sharing 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants