Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the values in the DropOffType enum doesn't make sense #44

Open
peetjvv opened this issue Dec 15, 2017 · 3 comments
Open

the values in the DropOffType enum doesn't make sense #44

peetjvv opened this issue Dec 15, 2017 · 3 comments

Comments

@peetjvv
Copy link
Contributor

peetjvv commented Dec 15, 2017

The values in the DropOffType enum were directly copied from PickupType. It would make sense to rather change them from e.g. NoPickup to NoDropOff and so on.
@xivk xivk closed this as completed Nov 15, 2019
@peetjvv
Copy link
Contributor Author

peetjvv commented Nov 15, 2019

I completely forgot about this issue. I see it was not resolved in my PR (#62 ), but was marked with TODOs to fix.

@xivk
Copy link
Contributor

xivk commented Nov 15, 2019

Sorry reopening...

@xivk xivk reopened this Nov 15, 2019
@peetjvv
Copy link
Contributor Author

peetjvv commented Nov 15, 2019

We're probably not going to get to implementing this fix anytime soon. Feel free to implement a fix on your side and bump the major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xivk @peetjvv