Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the standard IDisposable pattern in unsealed classes #16

Open
airbreather opened this issue Jan 5, 2019 · 1 comment
Open
Assignees
Labels

Comments

@airbreather
Copy link
Contributor

A few classes implement System.IDisposable, but they do so without using the standard pattern. See CA1063:ImplementIDisposableCorrectly, including its "See Also" links, for a description of this pattern.

I'm wrapping up what I intend to submit for the native memory array implementation, and in my self-review, I noticed that I don't have a finalizer on the type, which got me thinking about this.

The types I see that directly implement System.IDisposable are:

  • Reminiscence.Arrays.ArrayBase<T>
  • Reminiscence.Collections.List<T>
  • Reminiscence.Indexes.Index<T>
  • Reminiscence.IO.MemoryMap
  • Reminiscence.IO.MappedAccessor<T>
@xivk xivk self-assigned this Jan 10, 2019
@xivk xivk added the bug label Jan 14, 2019
@juliusfriedman
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants