Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding initial fastlane structure #2

Merged
merged 1 commit into from Oct 5, 2020
Merged

adding initial fastlane structure #2

merged 1 commit into from Oct 5, 2020

Conversation

IzzySoft
Copy link
Contributor

@IzzySoft IzzySoft commented Oct 3, 2020

This will be helpful…

  • if you wish to bring your app to F-Droid
  • for deploying your app to Google Play (this might need the Fastlane binaries)

Further, you might wish to move your screenshots from assets/ to fastlane/metadata/android/en-US/images/phoneScreenshots/ so they get picked up as well. I didn't do this with my PR here as I cannot tell what else (except for the ReadMe, which I could have easily adjusted) might depend on the original location 😉

@itsarjunsinh
Copy link
Owner

F-Droid availabilty has been part of my to-do list from the start. Since I don't have time at the moment to add Elder Launcher in the main F-droid repo, I'm keen on adding it through your third-party repo. Thanks for this PR.

After merging this, and once I move the screenshots is there anything else you require for the app to show up in your app repo?

@IzzySoft
Copy link
Contributor Author

IzzySoft commented Oct 5, 2020

Well, it already is in my repo – so if you want to place a badge next to the one of Google Play, be welcome 😄

Actually, this PR contains the Fastlane data I've currently setup locally for that. Just thought it a good idea to rather have it "upstream" in the app's repo, so you can adjust it easily when needed 😉 Just let me know once you've moved the screenshots into the Fastlane structure, so I adjust the config here to check them as well with each new version of the app released.

@itsarjunsinh itsarjunsinh merged commit 4ecb501 into itsarjunsinh:master Oct 5, 2020
@itsarjunsinh
Copy link
Owner

I've moved the screenshots. Thanks again for the PR.

@IzzySoft
Copy link
Contributor Author

IzzySoft commented Oct 5, 2020

Thanks for merging! But the screenshots need to be moved one level deeper, inside fastlane/metadata/android/en-US/images/phoneScreenshots – see my cheat-sheet for a quick reference. Your green feature graphic (I see one here) you could place as images/featureGraphic.png if you wish.

@itsarjunsinh
Copy link
Owner

Done. The cheat-sheet was helpful. I was actually trying to search for something like it before I made the previous commit.

@IzzySoft
Copy link
Contributor Author

IzzySoft commented Oct 5, 2020

Apologies, my bad – I should have mentioned it together with the screenshots before. I usually do, so it must have slipped through – I was working on 5 other such PRs and must have lost track… Thanks for your patience – and for adding the badge 😃

Wow, nice featureGraphic you got there – I replaced the old one right on the spot! Also updated the config, so from now on changes you make to the existing files will be picked automatically whenever there's a new release. Should you decide to add other types (like, per-release changelogs), please let me know so I enable them as well.

Now: all the best – and thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants