Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using Boot method for router call in Laravel's Service Provider #29

Closed
avr opened this issue Jan 11, 2014 · 2 comments
Closed

Comments

@avr
Copy link

avr commented Jan 11, 2014

I ran into an issue where there was no output in Chrome coming from Laravel 4.1.

Using the methods in #3, I was able to see that the headers were correctly being sent.

Moving the router call to the Service Provider's boot() method instead of the register() method fixed the issue for me.

Let me know if you'd like PR. Or, maybe using the boot method would cause other issues?

@itsgoingd
Copy link
Owner

Hey, can you test the latest version please? I've refactored the whole service provider, it should no longer break when initialised before router and be more compatible with other packages in general.

@avr
Copy link
Author

avr commented Jan 11, 2014

Just updated and things worked for me as expected. Thanks!

@avr avr closed this as completed Jan 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants