Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register new aliases #3

Closed
wants to merge 2 commits into from
Closed

Register new aliases #3

wants to merge 2 commits into from

Conversation

fdisotto
Copy link

@fdisotto fdisotto commented Jan 3, 2014

Hi, I've make some changes.
Now you can declare new facades with Facade::registerAliases without redeclare all preexistent facades and if you want, for example, use custom Log class you can redeclare Log alias because with my changes if alias exist replace existent class with new class.

@fdisotto
Copy link
Author

fdisotto commented Jan 3, 2014

Merge last commit, the other one is just a test that I have committed.

@itsgoingd
Copy link
Owner

Hey, sorry for the late reply, forgot about this somehow.
Thanks for your PR, but not registering default aliases when array of custom aliases is passed to the registerAliases method is a feature of the api, as sometimes you might wish to not register the default aliases (eg. In one of the legacy apps I work on there is already an App class in the global namespace). If you want to register both default and custom aliases, you can call the method multiple times, with and without the argument.

@itsgoingd itsgoingd closed this Mar 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants