Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] repaint & srolling performance issues #57

Open
jrson83 opened this issue Sep 8, 2023 · 0 comments
Open

[bug] repaint & srolling performance issues #57

jrson83 opened this issue Sep 8, 2023 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jrson83
Copy link
Collaborator

jrson83 commented Sep 8, 2023

Describe the bug

When enabling paint flashing and scrolling performance issues in dev tools and checking the iframe, it rerenders on scroll.

This is happening on both storylite app and story in new tab.

The issue for Story in new Tab is caused by overflow-x: hidden; applied to html, body, #root in storylite-iframe.css.
Removing the attribute, which is not necessary fixes the scrolling and repaint issue.

Update:
The issue for Story in new Tab is already fixed by #63.

For the app iframe, the issue is caused either by storylite-canvas-root or transition on iframe & canvas elements.
I'm still investigating. If I found the cause I will create a PR to fix repaint issues.

Update:
Since it is very hard to hunt down the cause of repaint, I hope this will be fixed by #65. Applying property will-change as workaround is not a good choice, instead better fix the real cause. It is really interessting that applying various height to elements can cause repaints.

Reproduction

  • Enable Paint flashing & Scrolling performance issues in chrome dev tools
  • Open the new story With Scrollbar
  • See the issue on the app iframe
  • Open story in new Tab with Toolbar
  • See the issue on the app id element

Environment

  • OS with version: Windows 11
  • Browser with version Chrome canary
  • JS Runtime with version: NodeJS v20.2.0
@itsjavi itsjavi added the bug Something isn't working label Sep 10, 2023
@jrson83 jrson83 self-assigned this Sep 11, 2023
@itsjavi itsjavi added this to the v1.0.0 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants