Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please allow a way for the file to be renamed before upload #1

Closed
Suyashtnt opened this issue May 23, 2020 · 2 comments
Closed

please allow a way for the file to be renamed before upload #1

Suyashtnt opened this issue May 23, 2020 · 2 comments
Assignees
Labels
invalid This doesn't seem right wontfix This will not be worked on

Comments

@Suyashtnt
Copy link

Suyashtnt commented May 23, 2020

i would like an optional parameter which allows you to change the name of the .jar before upload,
e.g

with:
token: ${{ secrets.CF_API_KEY }}
project_id: ID
game_endpoint: minecraft
file_path: build/libs/modid-1.0.jar
rename-file: mod.jar
changelog: updated mod, changelog on github
display_name: mod
game_versions: 1.15.2,Java 8,Forge
release_type: alpha

it will upload the exact thing of modid-1.0.jar, but will rename it to jarm.jar and upload the renamed file

@itsmeow
Copy link
Owner

itsmeow commented May 24, 2020

This is feature creep. Actions is an extremely dynamic platform. I'm sure there's an action that supports renaming files. Also, you need to set archivesBaseName in your buildscript properly and gradle will output the modid. If you set version it changes the version string. Sounds like you don't know how to use gradle.

@itsmeow itsmeow closed this as completed May 24, 2020
@itsmeow itsmeow self-assigned this May 24, 2020
@itsmeow itsmeow added invalid This doesn't seem right wontfix This will not be worked on labels May 24, 2020
@itsmeow
Copy link
Owner

itsmeow commented May 24, 2020

In fact, you don't even need an action to do this. This can be done with simple command exec actions and mv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants