Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input file_path accept first found .jar in folder path #7

Closed
Macleykun opened this issue Nov 21, 2021 · 4 comments
Closed

Input file_path accept first found .jar in folder path #7

Macleykun opened this issue Nov 21, 2021 · 4 comments

Comments

@Macleykun
Copy link

It would be handy if the file_path input would, if given only a path, to get the first occurrence of a .jar.
This way, people don't have to make an extra step to refer to the exact jar they want to upload.
If multiple .jar's are found, throw an warning but get the first occurrence.

You think this is a good idea?

@itsmeow
Copy link
Owner

itsmeow commented Nov 27, 2021

Eh. I like what's in the example action more. I use gradle variables myself to control this, you can export fields from the build step using the echo API of github actions.

@itsmeow itsmeow closed this as completed Nov 27, 2021
@Macleykun
Copy link
Author

What? Which variables? From actions/setup-java@v2 ?

@itsmeow
Copy link
Owner

itsmeow commented Jan 9, 2022

@Macleykun Apologies, I didn't see your reply until now. You can export variables from your Gradle buildscript into the GitHub actions step by using the echo API. Here's an example of me doing it: https://maven.itsmeow.dev/scripts/alphas.gradle
You can then reference those by using the ID of the step that runs the gradle build, just make sure you add an id to that step.
https://github.com/itsmeow/betteranimalsplus/blob/8088b11a1b1eb160ed676c7499c8e96686f90714/.github/workflows/gradle-releases.yml

@Macleykun
Copy link
Author

Sorry for the late reply!
Thank you! I now get it :D it's in gradle buildscript which makes alot of sense now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants