Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Do list: add & remove #2

Merged
merged 6 commits into from Aug 10, 2022
Merged

To Do list: add & remove #2

merged 6 commits into from Aug 10, 2022

Conversation

itsmraga-hub
Copy link
Owner

@itsmraga-hub itsmraga-hub commented Aug 10, 2022

馃挴 Achievements

  • Create a new JavaScript file with new functionality
  • Implement a function for adding a new task (add a new element to the array).
  • Implement a function for deleting a task (remove an element from the array).
  • Implement a function for editing task descriptions.
  • Save to localStorage.

Copy link

@sumairq sumairq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @itsmraga-hub ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 馃帀

Highlights

鉁旓笍 Good commit history
鉁旓笍Linters are passing
鉁旓笍Very professional README
鉁旓笍Correct Github flow
鉁旓笍Descriptive PR

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!馃憦馃憦馃憦

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@itsmraga-hub itsmraga-hub merged commit 5b6f09b into master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants