Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes with New version of react-native-video #12

Closed
mondoul opened this issue Dec 15, 2016 · 3 comments
Closed

Crashes with New version of react-native-video #12

mondoul opened this issue Dec 15, 2016 · 3 comments
Assignees

Comments

@mondoul
Copy link

mondoul commented Dec 15, 2016

Hi
with the newer version of React, react-native-video had to be updated to support onProgress and onLoad, but the controls are no longer working and the app crashes when trying to render.
To reproduce it, juste replace your dependency
"react-native-video": "^0.9.0" to
"react-native-video": ""git+https://github.com/react-native-community/react-native-video.git#master""

Thanks for your help

@kylemilloy kylemilloy self-assigned this Dec 15, 2016
@kylemilloy
Copy link
Contributor

Thanks for reporting this. I'll take a look over the weekend.

@mondoul
Copy link
Author

mondoul commented Dec 15, 2016

FYI, I stop having the issue if I remove playInBackground={ this.opts.playInBackground } from the render() method. It seems to be related to this issue

@kylemilloy
Copy link
Contributor

I can't repeat this issue but I'm going to start using the git repo for the react-native-video source for now as there's a couple bugs that RN 39 have created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants