Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: Using <Image> with children is deprecated. #55

Closed
travismgibson opened this issue Nov 1, 2017 · 4 comments
Closed

Warning: Using <Image> with children is deprecated. #55

travismgibson opened this issue Nov 1, 2017 · 4 comments

Comments

@travismgibson
Copy link

I am seeing the following warning:

Using with children is deprecated and will be an error in the near future. Please reconsider the layout or use instead.

Using:
"react": "16.0.0-beta.5",
"react-native": "0.49.3",
"react-native-video-controls": "^1.4.1"

@kylemilloy
Copy link
Contributor

Resolved in 1.5.1...thanks for bringing it up.

@travismgibson
Copy link
Author

Thanks for the quick follow up.

@rossmartin
Copy link

@kylemilloy

Thanks for being quick on this issue. When you added ImageBackground via 5f41a37 it breaks this component for anyone using RN 0.45 and lower. My app is using 0.45 and I had to install this package @1.5.0 in order for it to work. I kept getting the dreaded "you likely forgot to export your component from the file it's defined in". Just a heads up - I think if you mention to use 1.5.0 and lower if you're using RN 0.45 or lower is a reasonable solution.

Thanks for this component.

@kylemilloy
Copy link
Contributor

Good to know...I'll note the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants