Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create, open, sync btc, dcr and ltc wallet features #1

Merged
merged 4 commits into from Nov 8, 2023

Conversation

itswisdomagain
Copy link
Owner

No description provided.

Copy link

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only looked at decred, but looks simple and great. So much simpler.

asset/dcr/loader.go Show resolved Hide resolved
asset/dcr/sync.go Outdated Show resolved Hide resolved
asset/btc/loader.go Outdated Show resolved Hide resolved
asset/btc/loader.go Outdated Show resolved Hide resolved
asset/btc/wallet.go Outdated Show resolved Hide resolved
asset/btc/loader.go Outdated Show resolved Hide resolved
asset/btc/loader.go Outdated Show resolved Hide resolved
Comment on lines 46 to 47
// AddPeers: addPeers,
// ConnectPeers: connectPeers,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without these, does syncing connect to more than one peer? i think during initial btc implementation, we were only getting one peer connection

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spv peer manager borrowed from dex addresses this, I believe.

asset/btc/sync.go Outdated Show resolved Hide resolved
asset/btc/wallet.go Outdated Show resolved Hide resolved
@itswisdomagain itswisdomagain force-pushed the create-sync-features branch 3 times, most recently from 5c45c59 to 69c9171 Compare October 28, 2023 02:34
@itswisdomagain itswisdomagain merged commit 36de1eb into main Nov 8, 2023
@itswisdomagain itswisdomagain deleted the create-sync-features branch November 8, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants