Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce walletdata pkg for storing wallet config data and txs #3

Merged
merged 2 commits into from Nov 20, 2023

Conversation

itswisdomagain
Copy link
Owner

No description provided.

@itswisdomagain itswisdomagain force-pushed the configandtxsdb branch 2 times, most recently from e6138d2 to 8184ac3 Compare November 14, 2023 22:08
go.mod Outdated
@@ -2,6 +2,7 @@ module github.com/itswisdomagain/libwallet

require (
decred.org/dcrwallet/v3 v3.0.1
github.com/asdine/storm v2.1.2+incompatible
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cryptopower uses github.com/asdine/storm v0.0.0-20190216191021-fe89819f6282. Need to check that this version change doesn't cause unexpected troubles.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were you able to find anything?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.com/asdine/storm v0.0.0-20190216191021-fe89819f6282 is better. v2.1.2 is behind and does not have go.mod. Full comparison here: asdine/storm@v2.1.2...fe89819.

Copy link

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants