Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video does not pause when in PiP mode and screen is locked #4

Closed
itszechs opened this issue Jun 20, 2022 · 0 comments · Fixed by #6
Closed

Video does not pause when in PiP mode and screen is locked #4

itszechs opened this issue Jun 20, 2022 · 0 comments · Fixed by #6
Labels
bug Something isn't working

Comments

@itszechs
Copy link
Owner

Overview

When watching a video in PiP mode the video does not pause when you lock the screen

Suggested solution

https://github.com/itsZECHS/DriveStream/blob/150173816dd767998eeb28b9a6da346cf46cc4c0/app/src/main/java/zechs/drive/stream/ui/player/PlayerActivity.kt#L538-L540

I understand this is to prevent from pausing the video when it goes in PiP mode but it does more than it should so rather than checking for whether or not its in PiP Mode, keep track when onPause event is caused by PiP mode only then exempt pausing the video

@itszechs itszechs added the bug Something isn't working label Jun 20, 2022
@itszechs itszechs linked a pull request Jun 20, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant