Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads from Spiget include incompatible jars #72

Open
alvarlagerlof opened this issue Oct 21, 2021 · 10 comments
Open

Downloads from Spiget include incompatible jars #72

alvarlagerlof opened this issue Oct 21, 2021 · 10 comments

Comments

@alvarlagerlof
Copy link

https://www.spigotmc.org/resources/bungeetablistplus.313/

I using this results in errors because it includes jar files for sponge and more which are attempted to run. Is there way to fix this?

@itzg
Copy link
Owner

itzg commented Oct 21, 2021

I'm not sure how to help with this. If Spiget provided incorrect content, then report the issue with them. If the plugin content from Spigot is wrong then contact the plugin author.

You can add -e DEBUG=true if you need to see and report the exact spiget operations that were used.

@alvarlagerlof
Copy link
Author

I'm not sure the author is going to stop shipping a zip file if they have multiple versions though? I was thinking maybe of a block list?

@itzg
Copy link
Owner

itzg commented Oct 21, 2021

I'm sorry, now I'm even more confused. Can you provide the compose file or docker run command you're using? Maybe seeing what you're trying will help me.

@alvarlagerlof
Copy link
Author

Sure! Id 313 is what downloads a zip with a bunch of incompatible jars.

/bin/podman run
-it
-v /mnt/ssd/minecraft/%N/config:/config:ro
-v /mnt/ssd/minecraft/%N/plugins:/plugins:ro
-v /mnt/ssd/minecraft/%N/server:/server
--security-opt label=disable
--network minecraft
-p 25565:25577
-e SPIGET_PLUGINS=73064,313
-e TYPE=WATERFALL
-e ENABLE_RCON=true
-e MEMORY=256m
docker.io/itzg/bungeecord:latest

I use podman but the API is the same.

@itzg
Copy link
Owner

itzg commented Oct 22, 2021

Thanks for providing that. I'm not sure what I can do to fix this since my scripts just call the spiget API and have no control over the response from them.

@alvarlagerlof
Copy link
Author

Yeah I'm realizing that now too. The Spiget API doesn't seem to have any concept of "sub-resources" or the likes at all. And the plugin author says that they bundle them for convenience. There should be a real package manager for these plugins, imo.

The block list I was talking about was possibly to have the script rm files from a list, but the file names are not stable either, so that is of no use.

@alvarlagerlof
Copy link
Author

I would be able to improve my situation somewhat if PLUGINS also took zip urls as arguments.

@itzg
Copy link
Owner

itzg commented Oct 22, 2021

I would be able to improve my situation somewhat if PLUGINS also took zip urls as arguments.

That's an interesting idea. And for zips it would simply unzip the contents into the plugins directory?

@alvarlagerlof
Copy link
Author

That's an interesting idea. And for zips it would simply unzip the contents into the plugins directory?

Yes, exactly. I believe it already does this for Spiget resources that are zips?

unzip -o -q -d ${dest} "${tmpfile}"

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Please add a comment describing the reason to keep this issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants