Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Connection pools #162

Open
tmikaeld opened this issue Oct 9, 2023 · 1 comment
Open

Feature: Connection pools #162

tmikaeld opened this issue Oct 9, 2023 · 1 comment

Comments

@tmikaeld
Copy link

tmikaeld commented Oct 9, 2023

Since Redis itself is a serial protocol, we're limited to 1 command at a time, having a connection pool would solve this issue and drastically improve performance (Especially on multi-threaded redis like KeyDB).

I suggest a number by default to open multiple connections to the same port and an array of connections for custom hosts and ports (ex. for clusters).

@iuioiua
Copy link
Owner

iuioiua commented Oct 10, 2023

By default, I'd rather keep things as simple as possible. I'd be surprised if the current approach would ever be the source of a performance bottleneck and should be more than sufficient, in terms of performance, for most use cases. Either way, I'd happily look at a PR exploring this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants