Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Improve VR projection type detection #2394

Open
syeopite opened this issue Sep 11, 2021 · 1 comment
Open

[Feature request] Improve VR projection type detection #2394

syeopite opened this issue Sep 11, 2021 · 1 comment
Labels
enhancement Improvement of an existing feature help wanted Extra attention is needed research-needed

Comments

@syeopite
Copy link
Member

Is your enhancement request related to a problem? Please describe.

In order to render a VR video correctly, we need a projection type. Invidious currently attempts to detect this via the projectionType attribute in the adaptiveFormats.

def is_vr : Bool?
projection_type = info.dig?("streamingData", "adaptiveFormats", 0, "projectionType").try &.as_s
return {"EQUIRECTANGULAR", "MESH"}.includes? projection_type
end

However, this method isn't ideal:

  • EQUIRECTANGULAR always maps to a plain 360 projection
  • But MESH can refer to both the EAC projection and it's side-by-side variant: EAC_LR
  • Possibly more projection types?

Describe the solution you'd like

Find some full proof method to detect the exact projection type.

Describe alternatives you've considered

Since MESH can either be EAC or EAC_LR we can add a button to let the end-user quickly swap projection types so they can attempt to fix the video themselves.

Additional context

@syeopite syeopite added the enhancement Improvement of an existing feature label Sep 11, 2021
@SamantazFox SamantazFox added this to To Do - Backend / YT scraper in Todo - Invidious Sep 26, 2021
@syeopite syeopite moved this from To Do - Backend / YT scraper to Investigation required in Todo - Invidious Oct 25, 2021
@syeopite syeopite added help wanted Extra attention is needed research-needed labels Oct 25, 2021
@iBicha
Copy link
Contributor

iBicha commented Apr 12, 2024

Reviving this - is EQUIRECTANGULAR still being used? I haven't seen it in a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature help wanted Extra attention is needed research-needed
Projects
Todo - Invidious
Investigation required
Development

No branches or pull requests

2 participants