Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color change in the links and several improvements in the comments #334

Merged
merged 5 commits into from
Feb 3, 2019

Conversation

aaferrari
Copy link
Contributor

This is a summary with the modifications:

  • Change the color of the links in assets/css/lighttheme.css so that they are better distinguishable from the text. If you prefer you can omit this or use a different color.
  • In the comments API add the following parameters:
    • videoId: Necessary for permalinks of comments.
    • authorIsChannelOwner: To highlight the name of the video uploader in the comments from them.
    • creatorHeart: Optional, only in the comments that received a heart from the uploader. This in turn contains the fields creatorThumbnail and creatorName.
    • isEdited: To indicate if a comment was edited.
  • With the comments I did the following:
    • The text that indicates how much time has passed since its publication now shows the complete date when you hover the cursor over it. The text that formats the date was added in the translate function because it depends a lot on the country, but it would be missing some way of translate the days of the week and months according to the language of the user in a similar way to this.
    • Along with the time of publication add a link to see it also on Youtube (this could also be implemented for Invidious if it lets show a specific comment before the rest).
    • The name of the person who uploaded the video is highlighted from the rest.¹
    • It is indicated if a comment received a heart from the person who uploaded it¹ and if it was modified.
  • Due to the previous changes 4 additional strings were added in locales/en-US.json.

In the following screenshots you can better appreciate all the changes made:
comment example1
comment example2
comment example3

  1. This can be adjusted from the classes added in assets/css/default.css.

…e in the uploader comments and I finished permalink of the comments.
…om the uploader (plus additional classes in default.css). The isEdited attribute was also added in the comments API and new strings in en-US.json
assets/css/default.css Outdated Show resolved Hide resolved
@@ -4,6 +4,6 @@ a:active {
}

a {
color: #303030;
color: #0093ff;
Copy link
Contributor

@omarroth omarroth Feb 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would something like #606060 be better here? I also think links should be more noticeable, but this makes every a on the page a bright blue, so it's difficult to distinguish important information. Having only some links be this color (only links in the description, for example) would be better here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not convinced by the color #0093ff for all the links, I changed it to #61809b that I think achieves a good balance between making the links more noticeable but without being too bright. What do you think? Otherwise I have no problem in leaving it as it was and highlight only the links of certain sections (such as description or comments).

Copy link
Contributor

@omarroth omarroth Feb 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this comment before merging. If you'd like to open a new PR or a new issue I'd be happy to look at some proposed changes or continue discussion. I think #61089b looks fine though so I don't have a problem if you'd like to leave it.

@omarroth
Copy link
Contributor

omarroth commented Feb 2, 2019

Fantastic! I left a couple notes. Overall excellent and I'm excited to merge this.

@dimqua
Copy link
Contributor

dimqua commented Feb 2, 2019

@aaferrari did you test your changes also with dark theme?

@aaferrari
Copy link
Contributor Author

@dimqua I've been testing it with a couple of videos and it looks good. The change of colors in the links are limited to the light theme except for the highlighting of the name of who uploaded the video that applies to both themes (although if you think that in the dark theme it would be better of another color to let me know).

@omarroth
Copy link
Contributor

omarroth commented Feb 3, 2019

LGTM. 👍

@omarroth omarroth merged commit a1af27b into iv-org:master Feb 3, 2019
@dimqua
Copy link
Contributor

dimqua commented Feb 3, 2019

Awesome!

@aaferrari I suggest you to help omarroth with #118, if you have time and interest. It'd be really appreciated.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants