Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos in playlist getting duplicate #4080

Open
armin567ip opened this issue Aug 28, 2023 · 5 comments
Open

Videos in playlist getting duplicate #4080

armin567ip opened this issue Aug 28, 2023 · 5 comments
Labels
feature-request Request of a new feature module:playlists

Comments

@armin567ip
Copy link

Hi. let's say THIS video is in my playlist. and if I accidently click on adding to that playlist again. it's gonna get there again. which is a bug and it should only be there once or like display an error message that video already in playlist

@armin567ip armin567ip added the bug Something isn't working label Aug 28, 2023
@unixfox
Copy link
Member

unixfox commented Aug 28, 2023

To be fair, it's a really minor bug, just delete the duplicates yourself. It's probably because there is no check if a video already exists.

@armin567ip
Copy link
Author

armin567ip commented Aug 28, 2023

To be fair, it's a really minor bug, just delete the duplicates yourself. It's probably because there is no check if a video already exists.

Well I have an idea for you on how to get it fixed in the code.
You have to assign an ID for every video/shorts that is added to a playlist. And then for every video it has to check
If (id exists) then: error message
Else:
Add it to playlist.
Something like this. You got the idea

@k0zyrev
Copy link

k0zyrev commented Aug 30, 2023

This can't even be considered a bug. It's a feature. Say, you're creating a music playlist and you want one particular song to play after every second unique song in the playlist. Or maybe you want it to repeat exactly fifteen times and then go on to other songs. With your proposition it would be impossible.

@unixfox unixfox added feature-request Request of a new feature and removed bug Something isn't working labels Aug 30, 2023
@SamantazFox
Copy link
Member

SamantazFox commented Sep 9, 2023

Yeah, I see no point in adding such a restriction. It complicates the code, and add no real benefits.

I'm not against adding some logic to highlight duplicates, though, but that's likely to come at the cost of making large amounts of DB queries (either one large SELECT or multiple SELECT count(id)).

@ZIOOIZ8
Copy link

ZIOOIZ8 commented Apr 19, 2024

First of all, many thanks to all developers for these great possibilities that Invidious offers and that it exists at all. My suggestion on the subject would be to add an option in the settings where you can choose whether duplicates are allowed or not (I wouldn't link this to IDs, but simply to the name of the videos). For example, I like to create playlists so that I can organize videos by topic and refer back to them if I'm confronted with the same or similar topics again months later. It makes it a lot easier to find certain videos in your own playlists than if you have to search the whole of YT for them. However, over time such lists fill up and unfortunately there is no way to sort them, this function alone would help a lot to find duplicates and delete them yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request of a new feature module:playlists
Projects
None yet
Development

No branches or pull requests

5 participants