Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 2FA (OTP, U2F) #418

Open
Perflyst opened this issue Mar 18, 2019 · 15 comments · May be fixed by #2254
Open

Add support for 2FA (OTP, U2F) #418

Perflyst opened this issue Mar 18, 2019 · 15 comments · May be fixed by #2254
Assignees
Labels
enhancement Improvement of an existing feature

Comments

@Perflyst
Copy link
Contributor

Please add support for OTP (HOTP) and/or U2F. I am sure there are some librarys for this.

I personally prefer U2F as second factor more than OTP.

@omarroth omarroth added the enhancement Improvement of an existing feature label Mar 20, 2019
@omarroth
Copy link
Contributor

I assume this is for Invidious login, could you provide any more details on implementing them or what apps/devices they should be tested with?

@Perflyst
Copy link
Contributor Author

Well OTP is always probably the same. You can use a Nitrokey, Yubikey or also command line tools.
For U2F I personally can test with a Nitrokey.

@trymeouteh
Copy link

+1

This will increase account security. I always like services that support OTP for accounts. If invidious gets hacked the passwords get leaked accounts are still secure due to 2FA.

@ghost
Copy link

ghost commented Jun 16, 2020

i want to ask if there is any news on this feature ?
(OTP or U2F (FIDO))

@ghost
Copy link

ghost commented Jun 16, 2020

on the who, there is a library (MIT Licence) : https://github.com/lelag/otphp in php for doing OTP on login

@syeopite
Copy link
Member

Unfortunately Invidious is programmed in Crystal so a php library won't be compatible. Fortunately there are libraries for this and I'll be working on implementing it very soon!

@syeopite syeopite self-assigned this Jun 14, 2021
@syeopite syeopite added this to Planned in Todo - Invidious Jun 14, 2021
@unixfox
Copy link
Member

unixfox commented Jun 14, 2021

Unfortunately Invidious is programmed in Crystal so a php library won't be compatible. Fortunately there are libraries for this and I'll be working on implementing it very soon!

There is a library for crystal here: https://github.com/philnash/crotp

@syeopite
Copy link
Member

I'm aware. I'm currently just waiting for the maintainer to officially support Crystal 1.0 but I'll go ahead and fork it if needed.

@syeopite syeopite linked a pull request Jul 15, 2021 that will close this issue
@ghost
Copy link

ghost commented Dec 20, 2021

any news on this ?

@unixfox
Copy link
Member

unixfox commented Dec 20, 2021

No, a PR #2254 is pending but we still don't have the time yet for finishing it.

But if you want to contribute to the pull request you are free to do so :)!

@SamantazFox
Copy link
Member

The PR is mostly done, but we first need a database migration framework.

@ghost
Copy link

ghost commented Dec 20, 2021

No, a PR #2254 is pending but we still don't have the time yet for finishing it.

But if you want to contribute to the pull request you are free to do so :)!

i'm open to help but i do not know anything on crystal, so i can't help for that, will simply wait just wanted to know if we can hope to see it soon for up to date instance or if i must continue without it for now).

The PR is mostly done, but we first need a database migration framework.

Thanks for the answer ;)

@ghost
Copy link

ghost commented Jun 20, 2022

No, a PR #2254 is pending but we still don't have the time yet for finishing it.

But if you want to contribute to the pull request you are free to do so :)!

any news ?

@unixfox
Copy link
Member

unixfox commented Jun 20, 2022

No, a PR #2254 is pending but we still don't have the time yet for finishing it.
But if you want to contribute to the pull request you are free to do so :)!

any news ?

No, the developer that worked on this feature, syeopite, left the project so nobody is working on this feature anymore.

@ghost

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature
Projects
Status: Planned
Development

Successfully merging a pull request may close this issue.

6 participants