Videos: Use start time and end time for clips #4264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunkyProgrammer
requested review from
syeopite
and removed request for
a team
ChunkyProgrammer
force-pushed
the
use-start-time-and-end-time-for-clips
branch
from
26e660c
to
a596689
Compare
syeopite
approved these changes
Nov 20, 2023
ChunkyProgrammer
force-pushed
the
use-start-time-and-end-time-for-clips
branch
from
a596689
to
b344d98
Compare
SamantazFox
reviewed
Dec 10, 2023
ChunkyProgrammer
force-pushed
the
use-start-time-and-end-time-for-clips
branch
from
acb247c
to
07d47da
Compare
SamantazFox
reviewed
Dec 26, 2023
ChunkyProgrammer
force-pushed
the
use-start-time-and-end-time-for-clips
branch
from
07d47da
to
7da4a7f
Compare
SamantazFox
approved these changes
Jan 7, 2024
SamantazFox
added
the
need-testing
SamantazFox
reviewed
Jan 14, 2024
SamantazFox
added
ready
and removed
need-testing
SamantazFox
changed the title
SamantazFox
added a commit
that referenced
this pull request
Feb 12, 2024
This PR parses the start and end time for clips.
It also adds a new, dedicated API endpoint (`/api/v1/clips/{id}`) for
retrieving the start and end time of a clip.
Here is a sample response from that new endpoint (`video` is a video object,
as described in https://docs.invidious.io/api/common_types/#videoobject):
GET `/api/v1/clips/UgkxxPM3BRphCAPLP88YoUGuj79KXPfpNNO_?pretty=1`
Response:
```
{
"startTime": 8842.645,
"endTime": 8855.856,
"clipTitle": "✂️ Kirby is pink!",
"video": {}
}
```
Closes issue 3921
|
For some reason, Github didn't automatically close this PR when it was merged... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR parses the start and end time for clips.
closes #3921
FreeTubeApp/FreeTube#4323
Ex url: https://www.youtube.com/clip/UgkxxPM3BRphCAPLP88YoUGuj79KXPfpNNO_
API url:
/api/v1/clips/UgkxxPM3BRphCAPLP88YoUGuj79KXPfpNNO_?pretty=1API Response: