Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos: Add support for new likes format #4462

Merged

Conversation

ChunkyProgrammer
Copy link
Contributor

@ChunkyProgrammer ChunkyProgrammer commented Mar 2, 2024

YouTube added a new format for like data in December 2023. This PR adds support for parsing the like count on this new format.

Related: LuanRT/YouTube.js#557

closes #4419

@ChunkyProgrammer ChunkyProgrammer requested a review from a team as a code owner March 2, 2024 04:34
@ChunkyProgrammer ChunkyProgrammer requested review from SamantazFox and removed request for a team March 2, 2024 04:34
@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-new-likes-format branch from b1fe4ca to 581bb0b Compare March 2, 2024 04:41
@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-new-likes-format branch from ec4f97c to 5ceeefa Compare March 2, 2024 04:45
@SamantazFox SamantazFox added the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Mar 10, 2024
@stonerl
Copy link

stonerl commented Mar 10, 2024

I can confirm that this PR is working as intended. 👍

@Jisagi
Copy link

Jisagi commented Mar 19, 2024

Tested it myself by building the amd64 image based on the given branch and can confirm it working as well. img
Tested on everyones favorite ... the rick roll 😉

@SamantazFox
Copy link
Member

@stonerl @Jisagi thanks for testing this out :)

@SamantazFox SamantazFox removed the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Apr 24, 2024
@SamantazFox SamantazFox changed the title Add support for new likes format Videos: Add support for new likes format Apr 26, 2024
@SamantazFox SamantazFox merged commit 48ad864 into iv-org:master Apr 26, 2024
7 checks passed
@ChunkyProgrammer ChunkyProgrammer deleted the add-support-for-new-likes-format branch April 27, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Likes are always shown as 0.
4 participants