New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use wandb if not specified in the config file #1253
Conversation
Pull Request Test Coverage Report for Build 3933753469
💛 - Coveralls |
@kanishk16 do you mind reviewing this? if you cannot please let me know |
I'm sorry to stall the progress... On it right away... weirdly all the notifications were sent to my spam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1252 indicates that deliberate omission of the value in wandb_api_key
while logging in and the anonymous logging feature introduced in #1193 could sometimes be misleading and undesired. Hence, this undoes and simplifies it.
We'd also like to remove this from the documentation here. Specifically, the following should be removed from the docs:
From then on, the value in this key-value pair in the config file could be omitted, like 'wandb_api_key': ''
Yes! excellent catch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Will merge once tests pass!
Checklist
GitHub
PR contents
Description
#1252, even if the config file does NOT include any wandb field, training with ivadomed can use wandb in case wandb logging was previously done, indicates that deliberate omission of the value to
wandb_api_key
while logging in and the anonymous logging feature introduced in #1193 could sometimes be misleading and undesired. Hence, this PR undoes and simplifies it by bypassingwandb.login
call if the key is not defined or is empty.Linked issues
Resolves #1252