Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement intervertebral disc detection using pose estimation #539

Open
jcohenadad opened this issue Nov 24, 2020 · 8 comments
Open

Implement intervertebral disc detection using pose estimation #539

jcohenadad opened this issue Nov 24, 2020 · 8 comments
Labels
enhancement category: improves performance/results of an existing feature Good intership project Issue that could be developped into an interesting internship project

Comments

@jcohenadad
Copy link
Member

jcohenadad commented Nov 24, 2020

After implementing the first deep learning approach for detecting discs spinalcordtoolbox/spinalcordtoolbox#2679, we could investigate the post estimation method: mathis2018.pdf

@jcohenadad jcohenadad added enhancement category: improves performance/results of an existing feature Good intership project Issue that could be developped into an interesting internship project labels Nov 24, 2020
@rezazad68
Copy link
Collaborator

Just a quick update, the implementation of the pose estimation approach ( stacked hourglass network) for the training section is completed (not finalized). sample of validation result is attached. I Will update here regularly (in case of an issue) for further improvement and evaluation.
It seems to me the gaussian kernel is small and I need to fix it along with other things ...

86gt

@jcohenadad
Copy link
Member Author

Very cool! Thank you for the report @rezazad68 . I would suggest another choice of color-- it is very difficult to see the blue labels.

@rezazad68
Copy link
Collaborator

I have created a temporary repository to host the implementation code. Please check this link and guide me to solve issues (check the Issues to handle section). I highly appreciate your comments. Issues mostly related to the dataset.

@jcohenadad
Copy link
Member Author

I have created a temporary repository to host the implementation code. Please check this link and guide me to solve issues (check the Issues to handle section). I highly appreciate your comments. Issues mostly related to the dataset.

@rezazad68 I've briefly looked at the repos. It is very well documented, however I see a lot of code/feature duplication from ivadomed. E.g. the GIF generation and BIDS data loading are already implemented in ivadomed, so why not using them? That way, you can also create needed features in ivadomed, and it ensures your codebase will be compatible with ivadomed once your study is ready for publications. Currently it is not, there is a lot of hard-coded path/filenames in your code, eg:

@rezazad68
Copy link
Collaborator

Dataset Issue solved, as @jcohenadad suggested it was related to the wrong modality (T2w instead of T1w).

@jcohenadad
Copy link
Member Author

Dataset Issue solved, as @jcohenadad suggested it was related to the wrong modality (T2w instead of T1w).

cool! in the future, when you see an issue, could you please open an issue directly in your repos (if the issue is specific to your project) or in ivadomed repos (if issue is specific to ivadomed)-- it helps centralizing discussions-- otherwise we end up with a thread of 500+ post which is difficult to follow-- thx

@ssinad
Copy link

ssinad commented Jan 28, 2021

GitHub supports transferring issues in between repositories of the same user or organization.
https://docs.github.com/en/github/managing-your-work-on-github/transferring-an-issue-to-another-repository

@jcohenadad
Copy link
Member Author

thank you @ssinad in this case unfortunately this is another org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement category: improves performance/results of an existing feature Good intership project Issue that could be developped into an interesting internship project
Projects
None yet
3 participants