Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Disabling Show more context causes reversion #3

Open
ryadaj opened this issue Jul 18, 2023 · 5 comments
Open

[BUG] Disabling Show more context causes reversion #3

ryadaj opened this issue Jul 18, 2023 · 5 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@ryadaj
Copy link

ryadaj commented Jul 18, 2023

Disabling Show more context causes reversion to default search view. When re-enabling Show more context, default search view persists. Pressing enter in the search field restores "Better search view"

And it is, truly, wonderfully, better.

@ryadaj
Copy link
Author

ryadaj commented Jul 21, 2023

Same thing for Backlinks pane. In general, showing more context or not is disabled with this plugin.

@ivan-lednev
Copy link
Owner

Hello, @ryadaj, could you describe what you expect the button to do? For now the plugin grabs the whole section around a match by default, so in effect 'Show more context' is always enabled.

@ryadaj
Copy link
Author

ryadaj commented Jul 23, 2023

Ah, in that case please disregard!

@nhan000
Copy link

nhan000 commented Aug 16, 2023

I think it just needs some info in the documentations about this behavior because I was confused about it too, in both Search and Backlinks pane.

@7k50
Copy link

7k50 commented Oct 17, 2023

Thanks for making this plugin, it is exactly what I needed.

There is a problem. It seems that if you click the "Show more context" button, which collapses the context (after being expanded by default), and then click the button once more to expand the same content, then the markdown/etc will not restore render as before.


  1. When opening new page:
image



  1. Clicking "Show More Context" to collapse:
image



  1. Clicking "Show More Context" to expand back – the markdown/etc from the plugin is not restored:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants