Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore files, aparapi.jar removed and fixed path for MNIST datasets. #2

Merged
merged 4 commits into from Mar 30, 2014

Conversation

vojkog
Copy link
Contributor

@vojkog vojkog commented Mar 29, 2014

I've made few changes that enabled me to run MNIST junit tests successfully.
Not sure is the fixed RESOURCES_PATH a "best practice" (installation specific), but it makes downloading files into specific dir. easy.

Also, I've removed "aparapi.jar" from lib dir, it seems to me that it is redundant to maven version ("aparapi-2013_01_23.jar").

Please review.

ivan-vasilev added a commit that referenced this pull request Mar 30, 2014
.gitignore files, aparapi.jar removed and fixed path for MNIST datasets.
@ivan-vasilev ivan-vasilev merged commit a70bef7 into ivan-vasilev:master Mar 30, 2014
@ivan-vasilev
Copy link
Owner

Your contribution is more than welcome! I have only re-added lib/aparapi.jar, because it allows for gradle users not to rely on aparapi-2013_01_23.jar, because it's not available in the central maven repository and has to be added manually, when you work with maven.

@vojkog
Copy link
Contributor Author

vojkog commented Mar 30, 2014

Thx! Now, I see your point regarding aparapi.jar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants