UTF-8 support #128
Merged
UTF-8 support #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require php ^7.2 in order to use mb_ord, fix style
vinkla
reviewed
Mar 18, 2019
vinkla
reviewed
Mar 18, 2019
vinkla
reviewed
Mar 18, 2019
vinkla
reviewed
Mar 18, 2019
|
Thanks for the pull request @bonfante! Please see my comments. This pull request is featuring breaking changes and will require a new major release. @ivanakimov any thoughts? |
|
@vinkla done 👍. |
|
Thanks @bonfante! ✨ We'll bump the branch alias to 4.0, please try using the new version in any project. We'll release a new version in a week or two. |
|
https://github.com/symfony/polyfill-php72/blob/master/Php72.php#L191 |
|
That is great! We’ll probably leave it as it is since 7.1 will reach EOL this year anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UTF-8 support.
Extension mbstring become required and php ^7.2 to use mb_ord