Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ivanceras
Hi.
I love this crate more than diesel but not contains mysql support so i added it.
The big issue
r2d2-mysql wants connection as mutable for execute query but current signature of
Database
trait expects immutable.I added
Database2
,DBPlatform2
andEntityManager2
for keep API for postgres and sqlite.rust-postgres next varsion will be wanted mutable connection maybe (SEE).
I cloud not implement all of function of
Database
trait toDatabase2
trait.But i think it is enough for SELECT, INSERT, UPDATE and DELETE.
I hope merge this PR and then implement other function in after.
Please tell me if there are mistake in my code or thinking.
Thank you!