Show ideas one status at a time #164
Conversation
|
ping @ivandiazwm |
| $page = (int) $page; | ||
| $category = (int) $category; | ||
| $max = $this->getSetting('max_results'); | ||
| $from = ($page - 1) * $max; | ||
| $query = "SELECT * FROM ideas WHERE categoryid='$category' AND status !='new' ORDER BY "; | ||
| $query = "SELECT * FROM ideas WHERE categoryid='$category' AND status = '$status' ORDER BY "; |
There was a problem hiding this comment.
It seems the logic is flipped here. Why?
There was a problem hiding this comment.
This PR proposes a mechanism for filtering ideas by status. Here is the db query for fetching our data. new is still filtered out, but in the controller side. IMO, it's not the storage responsibility to assert that a status is never accessible.
| </ul> | ||
| </div> | ||
|
|
||
| <div style="color:#34495E"><small><?php echo $category->description; ?></small></div> |
There was a problem hiding this comment.
Please try to not use any inline styles.
Oops, I missed that. |
@prytoegrian The idea is definitely good and helpful when we have too many ideas to be filtered. Please make it a configurable option and let the rest of your changes run accordingly. Let us know once done, we will review, test and merge this PR asap. |
I felt very frustrated by the ideas current display so I improved it a little.
IMO, when an user want to see ideas, he doesn't really want to see all ideas. Only the current pipeline is important, ie. considered ideas. That's why the current status filter is set on 'considered'.
But, it might be useful to list ideas of another type, but only one status at a time. To support this UX I designed a select allowing to choose a status in header's list. Ideas obviously remain sorted by vote DESC.
For sure, I may be wrong and in that case, don't hesitate to close this PR.
Thanks !