Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the actual implementation from custom player use to using HTML5 player properties #5

Closed
ivandru opened this issue May 4, 2020 · 1 comment · Fixed by #6
Closed

Move the actual implementation from custom player use to using HTML5 player properties #5

ivandru opened this issue May 4, 2020 · 1 comment · Fixed by #6
Assignees
@ivandru
Labels
enhancement New feature or request
Milestone
0.0.1

Comments

@ivandru
Copy link
Owner

ivandru commented May 4, 2020

Move the actual implementation from custom player use to using HTML5 player properties. It will require to dump the injection approach and use only the content script approach.
Basically, the whole extension needs to be improved by controlling the HTML5 video player instead of playerInstance on the specific website.
@ivandru ivandru added the enhancement New feature or request label May 4, 2020
@ivandru ivandru added this to the 0.0.1 milestone May 4, 2020
@ivandru ivandru self-assigned this May 4, 2020
@ivandru ivandru linked a pull request May 4, 2020 that will close this issue
Feature "Move to HTML5 player based approach" #6
Merged
@ivandru
Copy link
Owner Author

ivandru commented May 4, 2020

Done in #6.

@ivandru ivandru closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivandru ivandru

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.0.1
Development

Successfully merging a pull request may close this issue.

Feature "Move to HTML5 player based approach" ivandru/custom-playback-speed-extension
1 participant
@ivandru