Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from local file instead of cdn in middlewares #330

Closed
jscheffner opened this issue Jun 2, 2023 · 1 comment
Closed

Import from local file instead of cdn in middlewares #330

jscheffner opened this issue Jun 2, 2023 · 1 comment

Comments

@jscheffner
Copy link

Hey, I just came across this comment on a different issue and was wondering if there are any opinions about this. I don't like depending on jsdelivr and would like to have everything included in my app. The files are already included in the npm package so for me it doesn't really make sense to import them via cdn.

Thank you for the PR, but for middleware middleware/render-voyager-page would it be possible to use a local file instead of the one from the cdn?
That way it could work offline locally.

#84 (comment)

@jscheffner
Copy link
Author

I guess serving the static files is a bit too complex so I'll close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant