Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: get rid of locales as generator-config #101

Closed
ivanhofer opened this issue Oct 13, 2021 · 1 comment
Closed

BREAKING: get rid of locales as generator-config #101

ivanhofer opened this issue Oct 13, 2021 · 1 comment

Comments

@ivanhofer
Copy link
Owner

ivanhofer commented Oct 13, 2021

Originally posted by ivanhofer October 2, 2021
This option only makes sense inside the rollup-process, so it should only be available there.

Currently the rollup- and webpack-process allows to configure the generator by passing it as an argument. This option should be removed and the config should always be loaded from the .typesafe-i18n.json-file. This would mean a breaking change so a error-massage should point to a migration-guide.

@ivanhofer
Copy link
Owner Author

ivanhofer commented Oct 13, 2021

The node-process is the recommended way to run the generator.

The rollup-plugin can be used to apply compile-time optimizations.
As of right now the webpack-plugin has no advantages. It can be used to start the generator when webpack is started.

Both plugins don't take generator-config options anymore,
Migrating is easy: just create a .typesafe-i18n,json in the root of your project and specify the options in that file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant