Recent getFallbackProxy changes breaks semver versioning

[jbergstroem]

Describe the bug

The change introduced in 5b83c01 breaks backwards compability for users that expects the name to be returned.

Not saying this is behavior wanted; but for some reason we had tests that leaned on it (which we will change).

Reproduction

Invoke getFallbackProxy and expect the translation key to be returned.

Logs

No response

Config

No response

Additional information

typesafe-i18n 2.60.1 (commit introduced with said version).

[ivanhofer]

@jbergstroem can you please tell what your tests currently look like and how you plan to change them?
This would help me understand the problem better and I will know if I need to just revert the changes from the fallback proxy or also add some logic to the actual Proxy object.

[jbergstroem]

@jbergstroem can you please tell what your tests currently look like and how you plan to change them?
This would help me understand the problem better and I will know if I need to just revert the changes from the fallback proxy or also add some logic to the actual Proxy object.

The test essentially relied on getting the key back as a way of validating that an error message was received when a form was posted in a certain way. The author later changed it to lean on another mechanism provided by the validation instead.

[ivanhofer]

So you don't actually initialize typesafe-i18n with valid translations inside your tests right?

[ivanhofer]

I have reverted the changes made to the fallbackProxy in version 2.60.2