Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the Gradle artifacts #56

Merged
merged 6 commits into from Oct 20, 2020
Merged

Fixed the Gradle artifacts #56

merged 6 commits into from Oct 20, 2020

Conversation

ivanisidrowu
Copy link
Owner

  • Add the Gradle artifacts.
  • Avoid compiler errors of the generated code for the Kotlin 1.3 users because of the trailing commas and the mixed index function parameters.

propertyToParseData.forEach { generateConstructor(it, funSpec) }
var index = 0
propertyToParseData.forEach {
generateConstructor(it, funSpec, index == propertyToParseData.size - 1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用 propertyToParseData.lastIndex 取代 size - 1 如何?

Copy link
Collaborator

@dev-weiqi dev-weiqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done !

Copy link
Collaborator

@dev-weiqi dev-weiqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@ivanisidrowu ivanisidrowu merged commit cf4de73 into develop Oct 20, 2020
@ivanisidrowu ivanisidrowu deleted the fix-artifacts branch October 20, 2020 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants